[Webkit-unassigned] [Bug 31266] [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable the Page Cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31266





--- Comment #7 from Andras Becsi <becsi.andras at stud.u-szeged.hu>  2009-11-11 01:08:12 PST ---
(In reply to comment #6)
> Oops, the last comment was incomplete. But as it said, we cannot add new
> functions to Qt 4.6 anymore :(
> 
> You are right that it seems that we are currently not enabling the page cache
> in WebCore::Settings. I'm not sure if that was introduced afterwards or if it's
> been missing since then.
> 
> My guts feeling is that it's probably best for now to keep it a global setting,
> i.e. to enable the page cache in all settings objects if there is a maximum set
> for pages in the page cache. Similarly we should disable it if the maximum is
> 0.
> 
> That can be done without adding new API and I think it gives us a sensible
> default. The only thing we're missing is the ability to turn off the page cache
> _per QWebPage_, but it is debatable whether that makes sense in the first
> place.
> 
> It is however a feature we can also introduce later on.

I understand and that's why I am experimenting with the globalSettings
singleton now which can be reached to enable and disable the page cache in
setMaximumPagesInCache as needed. This could work out. Shortly I will add a new
attachment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.