[Webkit-unassigned] [Bug 30291] When effectAllowed = "uninitialized", incorrect dropEffect returned

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30291


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42885|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2009-11-10 15:10:41 PST ---
(From update of attachment 42885)
r=me

But this test could be improved with one tiny change.

This line:

    shouldEvaluateTo('event.dataTransfer.dropEffect',
'dropEffectElem.options[dropEffectElem.selectedIndex].value');

Should be changed to:

    shouldBe('event.dataTransfer.dropEffect',
dropEffectElem.options[dropEffectElem.selectedIndex].value);

This would then make the test output easy to read because you could see the
actual result strings instead of the expression over and over again.

I'm really surprised by the shouldEvaluateTo function. I don't know who added
it and when, and I think I should look into this a bit more. When the second
argument is a string, it's the same as shouldBe, so I'm kind of mystified why
we would need it in that case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.