[Webkit-unassigned] [Bug 31293] Web Inspector: Enable 'console.profile()' and 'console.profileEnd()' regardless of JAVASCRIPT_DEBUGGER

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31293





--- Comment #3 from Timothy Hatcher <timothy at hatcher.name>  2009-11-10 13:38:20 PDT ---
(From update of attachment 42866)
> +#else
> +    bool profilerEnabled() const { return enabled(); }
>  #endif

This should likely return false, sicne there is no profiler.


>  #if ENABLE(JAVASCRIPT_DEBUGGER)
>      typedef HashMap<unsigned int, RefPtr<JSC::Profile> > ProfilesMap;
>  
>      void startUserInitiatedProfilingSoon();
> -    void toggleRecordButton(bool);
>      void enableDebuggerFromFrontend(bool always);
>      void getProfileHeaders(long callId);
>      void getProfile(long callId, unsigned uid);

Why isn't everything profile related moved out of the if
ENABLE(JAVASCRIPT_DEBUGGER) blocks? (Not just this file, other places too.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.