[Webkit-unassigned] [Bug 31291] Web Inspector: Speed up syntax highlighter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31291


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42865|review?                     |review-
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2009-11-10 09:26:36 PDT ---
(From update of attachment 42865)
> -                while (node.firstChild)
> -                    node.removeChild(node.firstChild);

Why isn't this needed in the loop anymore? (I see removeChildren was added
outside the loop.)


> -                this.lineFragment =null;
> +                this.newLine =null;

Add a space before null.


> -        action: identOrKeywordAction,
> -        dontAppendNonToken: true
> +        action: identOrKeywordAction

Why this change?

r- for the missing space.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.