[Webkit-unassigned] [Bug 31281] r50665 broke around 100 Qt layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31281


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42860|                            |review?
               Flag|                            |




--- Comment #2 from Csaba Osztrogonac <ossy at webkit.org>  2009-11-10 06:46:10 PDT ---
Created an attachment (id=42860)
 --> (https://bugs.webkit.org/attachment.cgi?id=42860)
proposed patch

FrameView::FrameView() set initial value of m_canHaveScrollbars(true), but
DumpRenderTree of Qt disable scrollbars by default:

WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp :
252        m_page->mainFrame()->setScrollBarPolicy(Qt::Horizontal,
Qt::ScrollBarAlwaysOff);
253        m_page->mainFrame()->setScrollBarPolicy(Qt::Vertical,
Qt::ScrollBarAlwaysOff);

If we call updateCanHaveScrollbars(), it makes QtBuildBot happy. :)

Only we have only one problem: The new fast/overflow/scrollbar-restored.html
won't work on Qt, because scrollbars are disabled by DumpRenderTree. After
resizing scrollbars won't be appear if it is disabled ...

Should we enable scrollbars? It would make some tests fail ...
Or should we skip only this new test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.