[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831





--- Comment #29 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-11-10 05:30:04 PDT ---
(In reply to comment #28)
> >>  #include <gdk/gdkx.h>
> >> +#define Bool int
> >> +#define Status int
> >> +#include <X11/extensions/Xrender.h>
> 
> > What are these for?
> 
> See getVisualAndColormap().  It's mostly copied from the Qt backend.  When a
> 32-bit visual is requested, we use XRender to find the most appropriate visual
> (that is, a visual with an alpha channel).  I'm not sure what the deal is with
> the defines: apparently *somewhere* a lot of the defines in the Xlib headers
> get undefined, including Bool and Status.  Xrender.h is not compilable without
> those defines.  (You'll also note elsewhere in the code that numbers are used
> instead of the constants for FocusIn, FocusOut, ButtonPress, etc., as it
> appears someone undefs those as well for some reason.  This behavior is present
> in the Qt-related file as well.)

Seems like a good idea to add a comment then
> 
> >> +    // On Unix, only call plugin if it's full-page or windowed
> >> +    if (m_mode != NP_FULL && m_mode != NP_EMBED)
> >> +        return;
> >
> > What does 'call plugin' mean? Calling setNPWindow?

Qt has issues with Flash as it is not being able to ref the GtkPlug, so I guess
Gtk doesn't need this particular piece of code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.