[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831





--- Comment #25 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-11-10 03:38:37 PDT ---
(In reply to comment #24)
> (From update of attachment 42765 [details])
> > -#if defined(XP_UNIX) || defined(Q_WS_X11)
> > +#if defined(XP_UNIX)
> >          bool m_needsXEmbed;
> >  #endif
> 
> I am wondering about these instances of this change in which we used to have
> both XP_UNIX, and Q_WS_X11. I wonder if the Qt people had a reason for this?
> Kenneth? Girish? =)

Simon had a comment about that, that if XP_UNIX is true, Q_WS_X11 is as well. 

> >  #include <gdk/gdkx.h>
> > +#define Bool int
> > +#define Status int
> > +#include <X11/extensions/Xrender.h>
> 
> What are these for?

The Bool and Status seems like redefines of some X typedefs. Girish are you
using XRender for the windowless support?

> We don't usually accept commented code into the tree, unless we plan to enable
> it soon, but then it would need a comment with a TODO mark.

I agree

> > +        if (gdkBackingStore) {
> > +            XCopyArea(GDK_DISPLAY(), GDK_DRAWABLE_XID(gdkBackingStore), m_drawable, gc,
> > +                      m_windowRect.x() + exposedRect.x() - xoff,
> > +                      m_windowRect.y() + exposedRect.y() - yoff,
> > +                      exposedRect.width(), exposedRect.height(),
> > +                      exposedRect.x(), exposedRect.y());
> > +        } else {
> > +            // no valid backing store; clear to the background color
> > +            XFillRectangle(GDK_DISPLAY(), m_drawable, gc,
> > +                           exposedRect.x(), exposedRect.y(),
> > +                           exposedRect.width(), exposedRect.height());
> > +        }
> 
> Both are single line calls, no need for the brackets.

It spans multiply lines, thus the coding style guide says to use braces.

> > +    // On Unix, only call plugin if it's full-page or windowed
> > +    if (m_mode != NP_FULL && m_mode != NP_EMBED)
> > +        return;
> 
> What does 'call plugin' mean? Calling setNPWindow?

the setNPWindow is supposed to be called on all changes to geometry (size or
position) according to the spec.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.