[Webkit-unassigned] [Bug 31047] [GTK] Failing test media/video-played-ranges-1.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31047


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42746|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #26 from Jan Alonzo <jmalonzo at gmail.com>  2009-11-10 01:34:38 PDT ---
(From update of attachment 42746)
r=me. I have a couple of minor suggestions though.

> +    // Position is available only if the pipeline is not in NULL or
> +    // READY state.
> +    if (position != GST_CLOCK_TIME_NONE)
> +        ret = (float) (position / 1000000000.0);

We tend to avoid C-style casts and use static_cast and friends (also exists in
a couple of places in this patch).

> +    gst_element_get_state(m_playBin,
> +        &state, &pending, 250 * GST_NSECOND);

And also we tend to not break into multiple lines where a one-liner would
suffice.

Other those it's ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.