[Webkit-unassigned] [Bug 31198] Can cache prototype lookups on uncacheable dictionaries.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31198


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42816|review?                     |review+
               Flag|                            |




--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2009-11-09 18:07:43 PDT ---
(From update of attachment 42816)
I don't like the name sortedProperties, partly because in the first loop, it
isn't yet sorted, partly because it was not immediately clear to me these were
pointers into the original map (modified by the entry-> writes).

I'm not sure what a good name would be, so I think a couple more comments
(like, "These writes are modifying the persistent property map for the
structure!".  Or something.)

And the variable name 'p' is kinda sucky, too.

But the code all looks sensible, r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.