[Webkit-unassigned] [Bug 31246] DateMath.cpp needs to be split into JSC and WTF portions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31246





--- Comment #3 from Geoffrey Garen <ggaren at apple.com>  2009-11-09 11:59:18 PDT ---
I don't think it's a good idea to split DateMath.cpp into JSC and WTF portions.

For one thing, I just did the opposite in bug 31197. I wish you hadn't reverted
my work without talking to me or even mentioning why. The comment I made in
that ChangeLog was:

"Moved most of the code in DateMath.* into the JSC namespace. The code needed
to move so it could naturally interact with ExecState and JSGlobalData to
support caching. Logically, it seemed right to move it, too, since this code is
not really as low-level as the WTF namespace might imply -- it implements a set
of date parsing and conversion quirks that are finely tuned to the JavaScript
language."

Do you disagree with this comment? If so, why?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.