[Webkit-unassigned] [Bug 31212] showTree(CounterNode*) generates too little info and has too many spaces.

Mon Nov 9 10:28:11 PST 2009

https://bugs.webkit.org/show_bug.cgi?id=31212

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42762|review?                     |review+
               Flag|                            |

--- Comment #9 from Darin Adler <darin at apple.com>  2009-11-09 10:28:10 PDT ---
(From update of attachment 42762)
Heh, I would have said "counter" instead of "current" -- nouns work better than
adjectives for variable names.

And the best function for writing one or two characters is probably fputc
rather than fwrite.

And on reflection I would probably use things like "parent", "prev" and "next"
instead of "P", "PS" and "NS".

r=me as is though, no need to go over and over this!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.