[Webkit-unassigned] [Bug 31083] EnableSecureEventInput is only called on PLATFORM(MAC)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 10:23:54 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31083





--- Comment #6 from Darin Adler <darin at apple.com>  2009-11-09 10:23:53 PDT ---
(From update of attachment 42429)
Clearly all the ports that don't compile on Mac OS X don't want this code.
Since Mac is taken to mean the native Mac WebKit, we may just need a filename
suffix that means anything running on the Mac platform, which could include Qt
or GTK or Chromium when compiling on Mac OS X.

One of the cleanest ways to refactor this would be to move the code into
WebCore/platform and just call it from Frame or SelectionController, since it's
definitely a bunch of "talking to the underlying platform" code just inline
there because it was written *so* long ago.

Side note: If we are touching this anyway, it would be good to move it to
SelectionController. As you can see in Frame.h, this is supposed to be moved
out of the Frame class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list