[Webkit-unassigned] [Bug 29231] Compiler warnings in InspectorResource.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29231


Martin Robinson <martin.james.robinson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.james.robinson at gmail
                   |                            |.com




--- Comment #8 from Martin Robinson <martin.james.robinson at gmail.com>  2009-11-09 10:01:57 PDT ---
(In reply to comment #7)
> > +        (WebCore::InspectorResource::):
> The above line is due to a bug in prepare-ChangeLog. It would be better to
> delete a line like that if you see it in your change log. The prepare-ChangeLog
> tool is there to help you write a log message, but you need to read and edit it
> before submitting it.

Noted for the future! 

> As far as the patch is concerned, it seems strange to remove the parentheses
> around the "&" subexpression but then add them around the new "&&"
> subexpression.

An unfortunate mistake on my part. Perhaps in the future, if this code is
improved, a tweak here can be in the fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.