[Webkit-unassigned] [Bug 30505] Counters aren't updated when a new counter-increment is added

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30505





--- Comment #11 from Shinichiro Hamaji <hamaji at chromium.org>  2009-11-09 08:13:11 PDT ---
(In reply to comment #9)
> (From update of attachment 42339 [details])
> It seems more elegant to me to delete the possibly-invalid counter nodes than
> to create new counter nodes just because something is going into the tree. The
> counter value may never be used and it seems unfortunate to compute its value
> explicitly instead of lazily. That having been said, the fix seems OK to me and
> won't have any effect on pages not using counters, so I'll say r=me

OK, I uploaded another patch with invalidating approach. Indeed, this approach
would be faster than the previous approach for usual (no-dynamic-change) cases.
Thank you for the comment!

> I think the name of the "counter" function, which I named, is extremely weak.
> It's really unclear you would call it to create a counter for its side effects.

Agreed. I'd like to create another patch to fix this naming, but I couldn't
figure out a good name for this function. Do you have any good idea for this?
createCounterNodeIfNeeded or something like this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.