[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #21 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-11-09 07:51:40 PDT ---
(In reply to comment #20)
> Created an attachment (id=42620)
 --> (https://bugs.webkit.org/attachment.cgi?id=42620) [details]
> gtk windowless v4
> 
> Changes from last patch:
> 
> * If needed, set the GdkColormap on the plugin's GdkPixmap wrapper (necessary
> if the plugin does not use gtk).
> * Don't bail on visual/colormap selection if xrender>=0.5 isn't found unless
> depth is also 32.
> * Add ChangeLog entry.
> 
> I'm feeling decently good about this.  It's not perfect, but it seems to work
> at least as well as the windowless support for Qt.  I'd like to get at least
> this much checked in if possible and then handle fixes/improvements as they
> become necessary.
> 
> There's also some work that can be done to avoid some code duplication between
> the Qt and gtk backends for this, which is probably best done in a future
> patch.

The patch looks good to me, knowing that you will work further on it. It has
some coding style violations thought:

+        GtkWidget *widget =
m_parentFrame->view()->hostWindow()->platformPageClient();
+        GdkDrawable *gdkBackingStore = NULL;


please run the check-webkit-style script.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.