[Webkit-unassigned] [Bug 31047] [GTK] Failing test media/video-played-ranges-1.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31047





--- Comment #24 from Jan Alonzo <jmalonzo at gmail.com>  2009-11-09 03:07:17 PDT ---
(From update of attachment 42739)
Some minor nits.

> +    if (position == GST_CLOCK_TIME_NONE) {
> +        // Position not yet available. Happens if the pipeline is in
> +        // NULL or READY state.
> +        ret = 0;
> +    } else

Can we move the comment before the conditional to avoid the braces?

> +        ret = (float) (position / 1000000000.0);
> +    LOG_VERBOSE(Media, "Position %" GST_TIME_FORMAT, GST_TIME_ARGS(position));
> +

Can you please add a space between ret and LOG_VERBOSE for clarity?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.