[Webkit-unassigned] [Bug 31066] [GTK] opening local files on win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 01:38:23 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31066


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42514|review?                     |review-
               Flag|                            |




--- Comment #10 from Jan Alonzo <jmalonzo at gmail.com>  2009-11-09 01:38:23 PDT ---
(From update of attachment 42514)
> +    #if PLATFORM(WIN_OS)
> +    response.setMimeType(g_content_type_get_mime_type(g_file_info_get_content_type(info)));
> +    #else
>      response.setMimeType(g_file_info_get_content_type(info));
> +    #endif

Were there any issues running the tests in WebKit/gtk/tests? You should be able
to add a test for this issue in one of the unit tests in that directory.

Also, there shouldn't be a space before #if/#else/#endif. 

r- because of the extra spaces. It would be nice if we have test for this too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list