[Webkit-unassigned] [Bug 31238] Web Inspector: Inspector should support copy() in the command line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31238


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42730|review?                     |review-
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2009-11-08 21:43:53 PDT ---
(From update of attachment 42730)
> +    void copyText(const String& text);
> +
>      // Generic code called from custom implementations.
>      void highlight(long nodeId);

Please move copyText into the "Generic code called from custom
implementations." (under that comment).


> +    var inspectorCommandLineAPI = evalFunction.call(evalObject, "window.console._inspectorCommandLineAPI = { \n\
> +        $: function() { return document.getElementById.apply(document, arguments) }, \n\
> +        $$: function() { return document.querySelectorAll.apply(document, arguments) }, \n\
> +        $x: function(xpath, context) \n\
> +        { \n\

I assume that the only change here is \n in the end (please confirm)?

r- for the copyText outside the injectedscript section, otherwise r+!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.