[Webkit-unassigned] [Bug 29231] Compiler warnings in InspectorResource.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29231


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42709|review?                     |review-
               Flag|                            |




--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2009-11-07 23:22:22 PDT ---
(From update of attachment 42709)
I think that after you patch hasChange(NoChange) will always be true. Hence
resources will stop updating due to the guard expression in
InspectorResource::updateScriptObject.
I guess what you should do is:

- remove NoChange at all
- introduce inline hasChanges that could return m_change != 0
- replace hasChange(NoChange) call with hasChanges
- and roll back rest (non need to change numbers).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.