[Webkit-unassigned] [Bug 31212] showTree(CounterNode*) generates too little info and has too many spaces.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31212


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42671|review?                     |review-
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2009-11-07 11:43:22 PDT ---
(From update of attachment 42671)
This is great!

> +        fprintf(stderr, "0x%08X %s: %d %d P:0x%08X PS:0x%08X NS:0x%08X R:0x%08X\n",
> +            current, current->isReset() ? "reset" : "increment", current->value(),
> +            current->countInParent(), current->parent(), current->previousSibling(),
> +            current->nextSibling(), current->renderer());

This won't compile without warnings under gcc. The specifier %08X takes an
"unsigned" as its argument, but we are passing in a pointer. The most portable
way to do this is probably to use %p instead of 0x%08X. Other solutions involve
converting the type by adding a typecast.

review- because this will break the build

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.