[Webkit-unassigned] [Bug 31206] Database can be the last to deref Document, resulting in ~Document on the Database thread.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31206





--- Comment #5 from Darin Adler <darin at apple.com>  2009-11-07 11:36:53 PDT ---
(From update of attachment 42663)
> +    // in case we're the last to reference the Document, deref it on the main thread
> +    callOnMainThread(derefDocument, m_document.release().releaseRef());

The comment isn't ideal.

It makes it sound like the issue is that we might be the last reference to the
document. But that's not true. The real issue is that we can't manipulate the
document's reference count at all on any thread other than the main thread.
This issue would exist even if ours was guaranteed to never be the last
reference to the document.

Further, our comment style is sentence formatting. It should be capitalized and
have a period.

Neither of these issues is serious enough that I think we should review- this,
but I wanted to mention both.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.