[Webkit-unassigned] [Bug 31224] [V8] Return return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31224


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42694|review?                     |review-
               Flag|                            |




--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-11-07 08:45:05 PDT ---
(From update of attachment 42694)
Thanks for tackling this! We just need a layout test and one small nit:

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 50615)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> +2009-11-07  Johnny Ding  <johnnyding.webkit at gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=31224
> +        Returns a StyleSheet object instead of HTMLStyleElement when using

Please update this to match the subject of the bug (including [V8] prefix).

> +        V8 engine to retrieve style sheet by a name from document.styleSheets


.
> +
> +        No new tests since it is only V8 binding issue.(JS binding is OK)

Well, this is an easily testable case, so I would say a layout test is in
order, regardless
of whether it's a bindings issue for one engine and not another.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.