[Webkit-unassigned] [Bug 31207] Web Inspector: Datatip should be a tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31207


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42693|review?                     |review-
               Flag|                            |




--- Comment #14 from Pavel Feldman <pfeldman at chromium.org>  2009-11-07 07:26:20 PDT ---
(From update of attachment 42693)
>              WebInspector.panels.scripts.evaluateInSelectedCallFrame(expression, false, objectGroup, callback);
> +            WebInspector.datatip.clearCache();
>              return;

Why is this needed? Console should not be aware of the datadip.


> +    getPropertiesCallback: function(properties)
> +    {
> +        this.__proto__.__proto__.getPropertiesCallback.call(this, properties);

WebInspector.ObjectPropertyTreeElement.prototype.getPropertiesCallback.call(this,
properties);

> +
> +        this.__proto__.__proto__.expand.call(this);

ditto

>  
> +    getPropertiesCallback: function(properties)
> +    {

This method is setting properties, why not to call it
setProperties(properties)?

>              InspectorController.resumeDebugger();
> +            WebInspector.datatip.clearCache();

Same here - scripts panel should not be aware of datatip. Otherwise we end up
with many bidirectional dependencies we don't need.
Shouldn't we lose focus by the time we get here.

>  
> +    this.datatip = new WebInspector.Datatip();

I guess it is here because of the calls above I don't like. We should get rid
of those and create datatip lazily for the sake of performance.

One more thing: I did not see any visual improvement since the last patch:
expansion is still happening to below the anchor even when the things don't
fit. And multiple overlapping paths still take place. No scrollers too. Could
you attach a screenshot?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.