[Webkit-unassigned] [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30623


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42550|review?                     |review-
               Flag|                            |




--- Comment #14 from Holger Freyther <zecke at selfish.org>  2009-11-07 01:09:47 PDT ---
(From update of attachment 42550)

> +        gchar* path = g_filename_from_uri(uri.utf8().data(), NULL, NULL);
> +        if (!path)
> +            continue;

^^^leaks scheme...

Use GOwnPtr here...


> +
> +        files.append(path);
> +        g_free(path);

^^^ Are you sure you want to create the String from ASCII?


> +    GdkPixbuf* m_image;
> +    GdkDragContext* m_dragContext;


Use a GOwnPtr here... this gets rid of all the if () unref if () ref things..



.. I stopped here for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.