[Webkit-unassigned] [Bug 31207] Web Inspector: Datatip should be a tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31207





--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2009-11-07 00:56:41 PDT ---
(From update of attachment 42687)
I'll let Tim finish the real review, but I'll list couple of problems that I
see:

1) Please add new js file into WebCore/WebCore.gypi and
WebCore.vcproj/WebCore.vcproj
2) You should layout each subsequent expansion separately so that say third
expansion would expand to 'above' the anchor if needed.
3) You don't limit size of the tip with visible area and provide no scrollers
when tip does not fit
4) If user moves mouse around and expands things, he gets them overlapping
(will attach screen). You should only show single 'path' to a property. Even
further - you should remove each 'tip' in the path on mouse leaving it.

I also don't like that we don't reuse Popup's code that was positioning wrt
anchor. Even though you don't need Popup behavior, you could try reusing popup
positioning. When we were doing Popup, we decided to use object with named
properties { x, y, width, height } for rect, not the class. Not that I liked
the idea, but now we definitely have a big overlap in utilities around rect
intersections, etc in different terms. Please merge / reuse code either way.
Ideal way would be to extract positioning from popup, migrate it to rect and
reuse in both places? We can do it later while we polish the datatip though, so
FIXME should be enough though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.