[Webkit-unassigned] [Bug 31050] [Multipatch] JSVALUE32_64 support on ARM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31050





--- Comment #6 from Gavin Barraclough <barraclough at apple.com>  2009-11-06 22:56:52 PDT ---
(From update of attachment 42648)
Hey Zoltan,

I haven't spotted an ASSERT / COMPILE_ASSERT guarding that
THUNK_RETURN_ADDRESS_OFFSET  matches the offset of thunkReturnAddress, did that
get missed?

Also, could we rename STRINGIZE_HELPER to STRINGIZE, and STRINGIZE to something
like STRINGIZE_VALUE, STRINGIZE_VALUE_OF, STRINGIZE_PREPROCESSED.  I think the
STRINGIZE macro should match the functionality of the stringize operator (#),
in just stringifying the token passed to it, and this is a useful macro in its
own right.  The version that doubly nests the macro to extract the value (if it
is a preprocessor token) is doing something more than the standard stringize
functionality, and I think it needs calling out as such.

Ah, now i see also the comment in JIT.h is also missing - so I'm guessing you
just hadn't got around to fixing the last review comments yet. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.