[Webkit-unassigned] [Bug 31067] Chromium crashes when a plugin invokes the document.open function via NPAPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 6 14:40:53 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31067


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42669|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2009-11-06 14:40:53 PDT ---
(From update of attachment 42669)
This looks great.  One typo:

 132     if (frame)
 133         htmlDocument->writeln(writeHelperGetString(args), frame ?
frame->document() : NULL);

We don't want the "if (frame)" here.  I can either fix this you on landing or
we can use commit-queue if you upload a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list