[Webkit-unassigned] [Bug 31204] WebInspector: RR for unit test of timeline data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31204


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42670|review?                     |review-
               Flag|                            |




--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2009-11-06 14:27:13 PDT ---
(From update of attachment 42670)
> +    // Synchronous opening of web inspector may fail on Windows

Wait a minute, we don't want that - we do run these on windows bots and need
tests to succeed. You'll need to put stuff under onload / ignoreLoad into
setTimeout to queue I guess once this one is reverted.


> +        // Invoke a setup method if it has been specified
> +        toInject.push("frontend_setup ? frontend_setup() : undefined");

"(if (frontend_setup) frontend_setup();)" ?



General comments: 
1. { } are used for single-line ifs all over the place
2. Use === instead of == for primitive types

Otherwise looks good.

Why added svn:executable flag?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.