[Webkit-unassigned] [Bug 29167] REGRESSION(r48064): mint.com loses scrollbars after coming out of edit mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29167


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42636|review?                     |review+
               Flag|                            |




--- Comment #14 from mitz at webkit.org  2009-11-06 11:22:25 PDT ---
(From update of attachment 42636)
Thanks for working on this!

I said that I will r+ this patch, but I do have one question and one comment:

>      ScrollbarMode hMode;
>      ScrollbarMode vMode;
> -    scrollbarModes(hMode, vMode);
> +    if (!m_canHaveScrollbars) {
> +        hMode = ScrollbarAlwaysOff;
> +        vMode = ScrollbarAlwaysOff;
> +    } else {
> +        scrollbarModes(hMode, vMode);
> +        if (hMode == ScrollbarAlwaysOff)
> +            hMode = ScrollbarAuto;
> +        if (vMode == ScrollbarAlwaysOff)
> +            vMode = ScrollbarAuto;
> +    }

Can’t you just use m_canHaveScrollbars to choose unconditionally between
ScrollbarAlwaysOff and ScrollbarAuto?

> -    void setCanHaveScrollbars(bool flag);
> +    virtual void setCanHaveScrollbars(bool flag);

You should remove the parameter name from the declaration.

As promised, r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.