[Webkit-unassigned] [Bug 23846] [GTK]Enable DNS prefetching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23846





--- Comment #16 from José Millán Soto <jmillan at igalia.com>  2009-11-06 10:10:48 PDT ---
(In reply to comment #14)
> (From update of attachment 41725 [details])
> > +static bool checkPrefetched(const String& hostname)
> > +{
> > +    static HashMap<String, double> lastTimePrefetched;
> > +    const double ttl = 60;
> 
> I would make this a #define. Any reason why you prefer to use a const variable?

I did it that way becouse it's suggested in WebKit coding style.

> > +    /*
> > +    soup_session_prepare_for_uri not yet avaliable:
> > +        https://bugzilla.gnome.org/show_bug.cgi?id=598948
> > +
> > +    String uri = "http://"+hostname;
> > +    SoupURI* soupUri = soup_uri_new(uri.utf8().data());
> > +    soup_session_prepare_for_uri(ResourceHandle::defaultSession(), soupUri);
> > +    soup_uri_free(soupUri);
> > +    */
> 
> We don't usually keep dead code. I would prefer just mentioning the bug report
> here.

Then I think the best solution is waiting for soup_session_prepare_for_uri to
be commited before changing this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.