[Webkit-unassigned] [Bug 31204] New: WebInspector: RR for unit test of timeline data

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 6 07:20:11 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31204

           Summary: WebInspector: RR for unit test of timeline data
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zundel at google.com
                CC: timothy at hatcher.name, knorton at google.com,
                    joepeck at webkit.org, pfeldman at chromium.org,
                    jaimeyap at google.com


This is more just to show a work in progress and show where I am going with the
LayoutTests for the Timeline data

There has not yet been an attempt to use Pavel's recently updated modular test
infrastructure.   I've been keeping all the test infrastructure in
timeline-test-api.js

Currently, the test turns on the timeline, reloads the page, then after the
page is loaded the second time, dumps all the inspector console messages and
timeline data.

The timeline data is scrubbed of events that appear to be related to the test
framework infrastructure by marking nodes with the console.markTimeline API.
The timeline data is also scrubbed of the start/end times which will cause the
layout test to fail 

I'm concerned that a test that looks like this will be too brittle and
difficult to tell when it needs updating, so I'm considering an even more
abbreviated format.  The new format would put each event on a different line,
indented with the level of nesting in order to make a diff come out looking
nice when the test fails.

Current:

{"children":[{"data":{"url":"file:///Users/zundel/apu-webkit/WebKit/LayoutTests/inspector/timeline-test-api.js","lineNumber":1},"children":[],"type":10},{"data":{"type":"load"},"children":[],"type":0},{"data":{"url":"file:///Users/zundel/apu-webkit/WebKit/LayoutTests/inspector/timeline-script-tag-1.html?reload","lineNumber":19},"children":[],"type":10}],"type":4}

would become:

ParseHTML
    EvaluateScript
    EventDispatch
    EvaluateScript

If we wanted more details on a particular event, maybe we could turn them on
for one test and get a record like this

timelineExpandEvent(TimelineAgent.RecordType.EventDispatch);

ParseHTML
    EvaluateScript
    EventDispatch :  {"data":{"type":"load"},"type":0}
    EvaluateScript


That way, we can write a test that is sensitive to the change to one event type
without causing all the timeline tests to fail.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list