[Webkit-unassigned] [Bug 5863] feMorphology filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5863


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42647|review?                     |review-
               Flag|                            |




--- Comment #16 from Nikolas Zimmermann <zimmermann at kde.org>  2009-11-06 06:08:08 PDT ---
(From update of attachment 42647)
Nice job Dirk,

some style nitpicks:

> +    if (m_radiusX == 0 || m_radiusY == 0)
> +        return;

if (!m_radiusX || !m_radiusY)


> +    radiusX = std::min(effectDrawingRect.width() - 1, radiusX);

I suggest to use "using std::min" / "using std::max" in the beginning.

> +                    if ((m_type == 1 && pixel <= columnExtrema) || (m_type == 2 && pixel >= columnExtrema))
...

> +                    if ((m_type == 1 && extrema[kernelIndex] <= entireExtrema) ||
> +                        (m_type == 2 && extrema[kernelIndex] >= entireExtrema))
...

Don't we have any named constants for this? Didn't check the source...
Please clarify these things, almost ready to give r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.