[Webkit-unassigned] [Bug 31047] [GTK] Failing test media/video-played-ranges-1.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31047





--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org>  2009-11-06 00:24:53 PDT ---
(In reply to comment #7)
> Created an attachment (id=42570)
 --> (https://bugs.webkit.org/attachment.cgi?id=42570) [details]
> fix playback rate setter

- in playbackPosition(): if returned position is GST_CLOCK_TIME_NONE (i.e. -1)
you shouldn't divide it and all that, but handle it different ;) At other
places positive or negative infinity is used for this.
- Add a comment why the "<0.8 || > 2" case is there, that's not obvious (nor
does it make much sense but the HTML5 spec says so)
- check if the rate in setRate() actually changes, if it doesn't you don't need
to do all that complex seeking stuff

Apart from that all patches look good to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.