[Webkit-unassigned] [Bug 30505] Counters aren't updated when a new counter-increment is added

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 16:29:03 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=30505


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42339|review?                     |review+
               Flag|                            |




--- Comment #9 from Darin Adler <darin at apple.com>  2009-11-05 16:29:03 PDT ---
(From update of attachment 42339)
It seems more elegant to me to delete the possibly-invalid counter nodes than
to create new counter nodes just because something is going into the tree. The
counter value may never be used and it seems unfortunate to compute its value
explicitly instead of lazily. That having been said, the fix seems OK to me and
won't have any effect on pages not using counters, so I'll say r=me

I think the name of the "counter" function, which I named, is extremely weak.
It's really unclear you would call it to create a counter for its side effects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list