[Webkit-unassigned] [Bug 31144] [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31144


Jakub Wieczorek <faw217 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42530|0                           |1
        is obsolete|                            |
  Attachment #42606|                            |review?, commit-queue?
               Flag|                            |




--- Comment #6 from Jakub Wieczorek <faw217 at gmail.com>  2009-11-05 15:29:33 PDT ---
Created an attachment (id=42606)
 --> (https://bugs.webkit.org/attachment.cgi?id=42606)
proposed patch

(In reply to comment #5)
> Looking at it a bit more you might want to use m_sawError in ::doEnd() to see
> if an error message has been sent during the parsing. And then it would be
> greatly appreciated if you could provide a layout test (your manual one with
> dumping as text would work) and finally see if we report an empty document as
> failure (or not).

Thanks, indeed the previous patch was wrong.

Here is a revised one that makes use of m_sawError to check if an error has
been encountered during the parsing to make sure the same failure would not be
reported twice.

I glanced through the fast/parser tests and noticed that
fast/parser/xml-declaration-missing-ending-mark.html demonstrates the same
problem. Therefore, I believe no new test is needed for this patch? That test
is currently on the Skipped list: it fails due to this bug but it also needs a
Qt-specific result. I'll file another bug with the correct test result.

The expected behaviour as for empty documents is preserved with this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.