[Webkit-unassigned] [Bug 31180] [v8] Do not retrieve handles in near death or empty state from the string impl cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31180





--- Comment #3 from anton muhin <antonm at chromium.org>  2009-11-05 15:19:56 PDT ---
First of all, I've found out that my previous fix didn't make into 4.0.223.16,
so I'd ask you to put this one on hold (I'd appreciate if you review+ it when
found in good shape, but I don't want it to be committed, at least for now).

(In reply to comment #2)
> (From update of attachment 42581 [details])
> + v8::Persistent<v8::String> handle(cachedV8String);
> 
> Why a Persistent handle?  Can we use a local handle here?

::IsNearDeath is only present on Persistent handles (Locals are always alive). 
If you're afraid of performance applications, AFAIK Persistent ctor (but not
::New) is roughly free.

> Can we test this?

I am lacking knowledge of our testing infrastructure.  The easiest way to check
it would be to write some notable amount of C++ code (to create an object with
a special weak reference callback, etc.) and expose it into JS.

Have we got something like that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.