[Webkit-unassigned] [Bug 30822] Change NativeImagePtr definition for wx port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30822





--- Comment #2 from Vadim Zeitlin <vz-webkit at zeitlins.org>  2009-11-05 15:09:08 PDT ---
I didn't measure this (it's difficult to see how to do it even remotely
accurately) but I'd expect the extra heap allocations to have noticeable effect
on performance so this change has more merits than just making the code more
sensible.

I'd also like to mention that CE port already uses a class (smart pointer class
but still) for this type so wx code wouldn't be the only exception. Of course,
there is the difference that CE NativeImagePtr can still be implicitly
constructed from NULL and converted to bool but realistically failing to use
NativeImagePtr() instead of NULL in common code can't remain unnoticed for long
as it would immediately break wxWebKit build.

Anyhow, I wonder if it's worth measuring performance gain from this change or
if it's not going to change your decision in any case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.