[Webkit-unassigned] [Bug 20780] when choosing an auto-completed value in a text input field the javascript 'change' event is not fired.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20780





--- Comment #24 from Darin Adler <darin at apple.com>  2009-11-05 10:11:26 PDT ---
Typically it's best to address new issues in a separate bug. The naming issue
is not the one this bug describes. And the automated commit queue tool works
best when each bug is resolved with a single patch.

(In reply to comment #23)
> Renamed RenderTextControl::m_edited to m_wasEditedSinceLastChangeEvent

Maybe it should be m_wasChangedSinceLastChangeEvent. I’m not sure setting the
text of a control counts as "being edited".

> RenderTextControl::m_userEdited to m_wasLastEditedByAUser

I don’t think "a user" is good here. We normally leave our articles from our
names. I also think that we should not call setting the text "being edited".
Perhaps m_wasEditedByUser is all we need for a good name here. Or maybe
m_lastChangeWasUserEdit. Maybe there's a better idea for the name. But in
general I think we should call changes done by the HTML editing commands
"editing" and other changes not be called editing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.