[Webkit-unassigned] [Bug 31137] Adds a cursory check of the ChangeLog in svn-create-patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31137





--- Comment #4 from Eric Ayers <zundel at google.com>  2009-11-04 13:58:11 PDT ---
(In reply to comment #2)
> (From update of attachment 42508 [details])
> 
> > +    if ($patch =~ /^\+\t/m) {
> > +        push(@styleMessages, " - ChangeLog contains leading tab character.");
> 
> No tabs are allowed, leading or otherwise.

Changed to spit out a warning on any tab char (after ignoring diff headers)

> 
> > +    if (!($patch =~ /^\+.*https:\/\/bugs.webkit.org\//m)) {
> > +        push(@styleMessages, " - No bug URL found in ChangeLog entry.");
> 
> Another valid format is http://webkit.org/b/XXXXX. If we care.

Done.

> > +            warn("* Problems found in ".$file.":\n" . join("\n", @styleMessages) . "\n");
> 
> Put spaces around the "."s or put $file directly in the string.

Done.


> r- for the tab check being restrictive.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.