[Webkit-unassigned] [Bug 31116] WebInspector: Corrects InspectorBackent::platform() on Windows.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 13:23:37 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31116


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42516|                            |review?, commit-queue?
               Flag|                            |




--- Comment #7 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2009-11-04 13:23:35 PDT ---
Created an attachment (id=42516)
 --> (https://bugs.webkit.org/attachment.cgi?id=42516)
Alternate solution patch: webkit port identifier

If we want to keep a WIN_OS wide platform identifier, I would rather use this
solution instead.

Unlike the PLATFORM macro on the C++ side, InspectorController.platform()
returns a single value that must identify both the webkit flavor and the OS.

Tell me if you prefer this solution or the first one, which should use
identifers like qt-windows, qt-mac, gtk-linux if needed to switch different
behavior/appearance of the inspector on different OS.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list