[Webkit-unassigned] [Bug 31137] Adds a cursory check of the ChangeLog in svn-create-patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31137


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42508|review?                     |review-
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2009-11-04 12:54:08 PDT ---
(From update of attachment 42508)

> +    if ($patch =~ /^\+\t/m) {
> +        push(@styleMessages, " - ChangeLog contains leading tab character.");

No tabs are allowed, leading or otherwise.


> +    if (!($patch =~ /^\+.*https:\/\/bugs.webkit.org\//m)) {
> +        push(@styleMessages, " - No bug URL found in ChangeLog entry.");

Another valid format is http://webkit.org/b/XXXXX. If we care.


> +            warn("* Problems found in ".$file.":\n" . join("\n", @styleMessages) . "\n");

Put spaces around the "."s or put $file directly in the string.

r- for the tab check being restrictive.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.