[Webkit-unassigned] [Bug 31044] [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31044


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |jmalonzo at gmail.com
     Ever Confirmed|0                           |1




--- Comment #4 from Jan Alonzo <jmalonzo at gmail.com>  2009-11-04 02:26:03 PDT ---
(In reply to comment #3)
> Created an attachment (id=42450)
 --> (https://bugs.webkit.org/attachment.cgi?id=42450) [details]
> use g_object_unref to free children (?)
> But I would like to understand this.... I tried:
> 
>     [...]
>     GOwnPtr<AtkObject> child(atk_object_ref_accessible_child(atkParent, i));
>     if (child == object)
>         return i;
> 
> This is working, we get a match, and we attempt to return i. At which point,
> GtkLauncher aborts. :-(

> Any suggestions regarding what I'm doing wrong/missing? Thanks!

The default implementation of freeOwnedGPtr (see JavaScriptCore/wtf/GOwnPtr.h)
uses g_free instead of g_object_unref. So to have an AtkObject use GOwnPtr, you
would need to "override" freeOwnedGPtr that will accept an AtkObject as a
parameter and that calls g_object_unref to free to object.

> 
> (Flagging for review in the hopes that the use of g_object_unref is fitting and
> appropriate.)

It's probably OK for this patch. But I think it's ideal if we could use GOwnPtr
for AtkObjects as well in the future. 

r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.