[Webkit-unassigned] [Bug 30909] 10.6 SDK building for 10.5: GraphicsContextCG.cpp:1056: warning: enumeration value 'kCGInterpolationMedium' not handled in switch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30909





--- Comment #25 from Mark Rowe (bdash) <mrowe at apple.com>  2009-11-03 23:25:47 PDT ---
(From update of attachment 42418)
> Index: WebCore/platform/graphics/cg/GraphicsContextCG.cpp
> ===================================================================
> --- WebCore/platform/graphics/cg/GraphicsContextCG.cpp	(revision 50468)
> +++ WebCore/platform/graphics/cg/GraphicsContextCG.cpp	(working copy)
> @@ -43,10 +43,16 @@
>  #include <wtf/OwnArrayPtr.h>
>  #include <wtf/RetainPtr.h>
>  
> -#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> +#if PLATFORM(DARWIN) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)

CoreGraphics is well above the Darwin layer so it’s odd to suggest that Darwin
is somehow relevant to this decision.

> @@ -1061,9 +1067,15 @@ InterpolationQuality GraphicsContext::im
>      case kCGInterpolationLow:
>          return InterpolationLow;
>  #if HAVE(CG_INTERPOLATION_MEDIUM)
> +    // kCGInterpolationMedium is known to be present in the CGInterpolationQuality enum.
>      case kCGInterpolationMedium:
> +#if USE(CG_INTERPOLATION_MEDIUM)
> +        // Only map to InterpolationMedium if targeting a system that understands it.
>          return InterpolationMedium;
> -#endif
> +#else
> +        return InterpolationDefault;
> +#endif  // USE(CG_INTERPOLATION_MEDIUM)
> +#endif  // HAVE(CG_INTERPOLATION_MEDIUM)
>      case kCGInterpolationHigh:
>          return InterpolationHigh;
>      }

It’s surprising to me that the !USE(CG_INTERPOLATION_MEDIUM) case returns
InterpolationDefault while !HAVE(CG_INTERPOLATION_MEDIUM) returns
InterpolationHigh.  Is there some reason for that difference?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.