[Webkit-unassigned] [Bug 31067] Chromium crashes when a plugin invokes the document.open function via NPAPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 21:52:35 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31067


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42435|review?                     |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2009-11-03 21:52:35 PDT ---
(From update of attachment 42435)
This looks great.  A couple minor issues:

 123     if (frame)
 124         htmlDocument->write(writeHelperGetString(args),
frame->document());

We can call htmlDocument->write even when |frame| is null.  We can just pass a
null second argument.

In your LayoutTest/ChangeLog, you have several copies of the change
description.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list