[Webkit-unassigned] [Bug 31091] New: commit-queue is crashing when trying to reject patches after unknown failures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31091

           Summary: commit-queue is crashing when trying to reject patches
                    after unknown failures
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org


commit-queue is crashing when trying to reject patches after unknown failures

Traceback (most recent call last):
  File "WebKitTools/Scripts/bugzilla-tool", line 917, in <module>
    main()
  File "WebKitTools/Scripts/bugzilla-tool", line 914, in main
    return tool.main()
  File "WebKitTools/Scripts/bugzilla-tool", line 909, in main
    return command_object.execute(command_options, command_args, self)
  File "WebKitTools/Scripts/bugzilla-tool", line 762, in execute
    tool.bugs.reject_patch_from_commit_queue(patch['id'], "Unexpected failure
when landing patch!  Please file a bug against bugzilla-tool.\n%s" %
e.message_with_output())
NameError: global name 'patch' is not defined

This is a really bad place to crash, because we never learn what's actually
wrong. :)

I've fixed this.  I also noticed we're leaking file descriptors in this case,
so I've fixed that as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.