[Webkit-unassigned] [Bug 31035] [GTK] some accessibility tests hitting assertion in debug builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31035


Joanmarie Diggs <joanmarie.diggs at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42359|0                           |1
        is obsolete|                            |
  Attachment #42426|                            |review?
               Flag|                            |




--- Comment #8 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-11-03 15:11:15 PDT ---
Created an attachment (id=42426)
 --> (https://bugs.webkit.org/attachment.cgi?id=42426)
Replace assertions with sanity checks - take 2

(In reply to comment #7)
> (From update of attachment 42359 [details])
> > +    AccessibilityObject::AccessibilityChildrenVector children = coreObject->children();
> > +    if (index < 0 || index >= children.size())
> > +        return 0;
> >  
> >      AccessibilityObject* coreChild = coreObject->children().at(index).get();
> 
> It would be nice if we can just reuse children here instead of calling to
> coreObject again.

Yup. Done. Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.