[Webkit-unassigned] [Bug 31082] Web Inspector - Adds markTimeline() API to the console for annotating the timeline tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31082


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42415|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2009-11-03 14:18:20 PDT ---
(From update of attachment 42415)
> +{
> +    if (timelineAgent())
> +      timelineAgent()->didMarkTimeline(message);

wrong indent

> +        MarkTimelineRecordType = 11,

will be a conflict with resources events, who gets r+ first? :)

> +    page->inspectorController()->markTimeline(message);

we could pass the stack and try doing .log-alike the formatting, but that is
too hard.

r- for indent. otherwise good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.