[Webkit-unassigned] [Bug 30909] 10.6 SDK building for 10.5: GraphicsContextCG.cpp:1056: warning: enumeration value 'kCGInterpolationMedium' not handled in switch

Tue Nov 3 13:06:43 PST 2009

https://bugs.webkit.org/show_bug.cgi?id=30909

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42410|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #22 from Eric Seidel <eric at webkit.org>  2009-11-03 13:06:43 PDT ---
(From update of attachment 42410)
I'm sorry this simple change has taken so much back-and-forth.  I think this
patch looks good.  Although personally I would prefer the HAVE/USE stuff to be
defined only in the CG file, since it makes little sense for all ports to see
it (Which they do with it in config.h).

+    // Fall through to InterpolationHigh if kCGInterpolationMedium is not
usable
should have a period after a full sentence.

Anyway, LGTM, but I would like to see the defines you added to config.h moved
back to platform/graphics/cg/GraphicsContextCG.cpp instead.  I'll mark r+ and
let you land this manually with modifications.  Mark or Darin can give further
comments/instructions if they disagree with that approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.