[Webkit-unassigned] [Bug 31080] New: WebInspector: Handle turning TimelineAgent on/off in the middle of an event dispatch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31080

           Summary: WebInspector: Handle turning TimelineAgent on/off in
                    the middle of an event dispatch
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zundel at google.com
                CC: timothy at hatcher.name, knorton at google.com,
                    pfeldman at chromium.org


Currently, If you enable or disable the timeline agent in the middle of a
dispatch, you get undefined behavior when it hits the end of an instrumentation
point.  The InspectorTimelineAgent* is being saved from the time the event
started to the time it ended.  

To fix the problem when timeline profiling is turned off in the middle of
processing an event, the pointer needs to be retrieved each time to make sure
it is still valid.  For the case where timeline profiling is turned on in the
middle of an event, the case where the stack of instrumented events is empty
should be silently ignore, not asserted.

This patch doesn't fix each instrumentation point, but gives an example of what
I propose.  I can add on to this patch or submit a subsequent patch.

I made an unrelated change to make the check-webkit-style script run cleanly on
ScriptController.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.