[Webkit-unassigned] [Bug 31049] Watch expression editor should stay open after Add button was clicked

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 09:33:38 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31049





--- Comment #6 from Patrick Mueller <pmuellr at yahoo.com>  2009-11-03 09:33:38 PDT ---
(In reply to comment #5)
> BTW, do we really need to call update and reevaluate all the expressions when a
> new one is added?

Probably not.  

OTOH, optimizing to JUST evaluate the new expression will likely add more code,
so not clear if it's really worth it, given the probably relative infrequency
that people will be updating watch expressions.

Part of the problem is also that the WatchExpressions classes subclass
ObjectProperties sections, which don't (IIRC) have fine-grained control over
dealing with individual members.  Hence the kinda hacky findAddedTreeElement()
function.  Perhaps some additional goodies in the superclasses would make
optimizing this a bit easier.

Note also that, in general, we don't really update enough.  For instance, we
don't update after a line is executed on the console, but probably should.  You
could also imagine updating after every UI event that occurs in the target
(well, except some of the excessive mouse events).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list